search

f5devcentral / ansible-role-f5_atc_deploy_declaration

Ansible role used to deploy declaratives to F5 Automated Tool Chain services: AS3, DO, and TS
Apache License 2.0
7 stars 11 forks source link

Default server_port (and other provider defaults) #37

Open tabernarious opened 3 years ago

tabernarious commented 3 years ago

Due to variable order of precedence, a set_fact used within a role cannot overwrite the provider included in a playbook as a role parameter. To work around this I set a default_provider in defaults/main.yml, created a role_provider dictionary in tasks/main.yml using the combine filter (to combine the defaults with the role parameters set in the playbook), and updated all of the references from provider.xxx to role_provider.xxx. I'm open to other ideas/methods.

Also split off provider setup and set no_log: true to prevent accidental password leakage via -vv etc. Note, this does not necessarily prevent debug from exposing the password.

This pull includes the additions of delegate_to: localhost referenced in my other Pull Request:

https://github.com/f5devcentral/ansible-role-f5_atc_deploy_declaration/pull/36

tabernarious commented 3 years ago

I committed and pushed a fix for the Travis CI build failure, which is showing in my branch, but is not showing here. Maybe it just takes time to trigger the updates...?

UPDATE: It just took some time. Branch updated and all checks have passed.

https://github.com/tabernarious/ansible-role-f5_atc_deploy_declaration/tree/default_server_port