f5devcentral / f5-automation-config-converter

Convert BIG-IP configs to AS3 and DO declarations
https://clouddocs.f5.com/products/extensions/f5-automation-config-converter/latest/
Apache License 2.0
35 stars 13 forks source link

Nonexistent property for Service_Generic: vlansEnabled #34

Closed azahajkiewicz closed 3 years ago

azahajkiewicz commented 3 years ago

Environment

Summary

Charon wrongly convers VS property: vlans-enabled to vlansEnabled instead of allowVlans

Steps To Reproduce

Steps to reproduce the behavior:

  1. Convert following config:

    ltm virtual /tenant_1/application_1/test_vs {
    description "Created by Web Configuration Utility for PEM Listener test_vs"
    destination /tenant_1/application_1/0.0.0.0:80
    ip-protocol udp
    mask any
    profiles {
        /Common/classification_pem {
            context clientside
        }
        /tenant_1/application_1/test_profile {
            context clientside
        }
        /Common/udp_decrement_ttl { }
    }
    source 10.10.10.100/32
    source-address-translation {
        pool /Common/cgnat-pool
        type lsn
    }
    translate-address disabled
    translate-port enabled
    vlans-enabled
    }
  2. Observe the following error message:

    {
    "code": 422,
    "message": "Invalid data property: vlansEnabled"
    }

when deploying generated declaration:

 "test_vs": {
                "remark": "Created by Web Configuration Utility for PEM Listener test_vs",
                "layer4": "udp",
                "translateServerAddress": false,
                "translateServerPort": true,
                "vlansEnabled": "",
                "class": "Service_Generic",
                "profileClassification": {
                    "bigip": "/Common/classification_pem"
                },
                "profileEnforcement": {
                    "use": "/tenant_1/application_1/test_profile"
                },
                "virtualAddresses": [
                    [
                        "0.0.0.0/0",
                        "10.10.10.100/32"
                    ]
                ],
                "virtualPort": 80,
                "persistenceMethods": []
            },

Expected Behavior

Instead vlansEnabled, charon should use: allowVlans as per documentation for Service_Generic: https://clouddocs.f5.com/products/extensions/f5-appsvcs-extension/latest/refguide/schema-reference.html#service-generic

Actual Behavior

Charon converts vlans-enabled to vlansEnabled instead of allowVlans property.

azahajkiewicz commented 3 years ago

Please double check scenario when vlans-enabled in bigip.conf is empty - if allowVlans property should be present / what should be the exact value of allowVlans property .

mdditt2000 commented 3 years ago

@azahajkiewicz agree we should be using allowVlans (array). However if vlans-enabled in bigip.conf is empty we maybe document allowVlans as unsupported due to missing vlan.

mdditt2000 commented 3 years ago

Filed Jira CHARON-318 for PM tracking

mdditt2000 commented 3 years ago

Merge branch 'vlans_enabled' into 'develop. Closing issue as complete