f5devcentral / f5-automation-config-converter

Convert BIG-IP configs to AS3 and DO declarations
https://clouddocs.f5.com/products/extensions/f5-automation-config-converter/latest/
Apache License 2.0
35 stars 13 forks source link

md5-signature-passphrase option cause declaration failure in specific conditions. #70

Closed lukaszbrzosko closed 2 years ago

lukaszbrzosko commented 3 years ago

Environment

Application Services Version: 3.31.0 BIG-IP Version: 14.1.4

Summary

Declaration deployment fail if tcp profile have those options: md5-signature disabled md5-signature-passphrase none

Steps To Reproduce

Steps to reproduce the behavior:

  1. Convert following config:
    ltm profile tcp /Common/nowy1 {
    app-service none
    defaults-from /Common/tcp
    md5-signature disabled
    md5-signature-passphrase none
    }

result in:

{
    "class": "ADC",
    "schemaVersion": "3.30.0",
    "id": "urn:uuid:7008f826-5edc-4686-b0a5-9f7494f95aa4",
    "label": "Converted Declaration",
    "remark": "Auto-generated by AS3 Config Converter",
    "Common": {
        "class": "Tenant",
        "Shared": {
            "class": "Application",
            "template": "shared",
            "nowy1": {
                "md5SignaturePassphrase": {
                    "ciphertext": "bm9uZQ==",
                    "protected": "eyJhbGciOiJkaXIiLCJlbmMiOiJub25lIn0=",
                    "ignoreChanges": true
                },
                "class": "TCP_Profile"
            }
        }
    }
}
  1. Observe the following error message one declaration send to device:
    {
    "code": 500,
    "declarationFullId": "",
    "message": "POST http://admin:XXXXXX@localhost:8100/mgmt/tm/ltm/auth/radius-server/ response=400 body={\"code\":400,\"message\":\"\\\"secret\\\" is a required property and may not be set to \\\"none\\\" or an empty value\",\"errorStack\":[],\"apiError\":26214401}"
    }

Expected Behavior

If we have md5-signature disabled we should not get md5-signature-passphrase with empty value. Perhaps we should not get this at all.

Actual Behavior

None is converted as value which results in declaration deployment failure.

mdditt2000 commented 3 years ago

Jire filed CHARON-525 for ACC 1.17

mdditt2000 commented 2 years ago

Merge branch 'CHARON-525-tcp-profile-md5-sig' into 'develop' - Closing issue