andle wildcards in monitor destinations

[lukaszbrzosko]

Environment

• ACC Version: 16.1.0
• AS3 Version: 3.32.0
• BIG-IP Version: 14.1.4

Summary

If there is no Ip address given in alias for tcp ( and maybe others) monitor but port is defined there is a problem with convertions.

Steps To Reproduce

Steps to reproduce the behavior:

1. Convert following config:

   ltm monitor tcp /Common/test_target {
   adaptive disabled
   defaults-from /Common/tcp
   destination *.514
   interval 5
   ip-dscp 0
   recv none
   recv-disable none
   send none
   time-until-up 0
   timeout 3
   }

   Converted to:

   {
   "class": "ADC",
   "schemaVersion": "3.31.0",
   "id": "urn:uuid:52857963-00c9-4a7b-b198-5e616808e7fe",
   "label": "Converted Declaration",
   "remark": "Auto-generated by AS3 Config Converter",
   "Common": {
       "class": "Tenant",
       "Shared": {
           "class": "Application",
           "template": "shared",
           "test_target": {
               "adaptive": false,
               "dscp": 0,
               "receive": "",
               "receiveDown": "",
               "send": "",
               "timeout": 3,
               "class": "Monitor",
               "monitorType": "tcp",
               "targetAddress": "*.514",
               "transparent": false,
               "reverse": false
           }
       }
   }
   }              

//////////////////OR :

ltm monitor tcp /Common/test_target {
    adaptive disabled
    defaults-from /Common/tcp
    destination *:514
    interval 5
    ip-dscp 0
    recv none
    recv-disable none
    send none
    time-until-up 0
    timeout 3
}

Converted to:

{
    "class": "ADC",
    "schemaVersion": "3.31.0",
    "id": "urn:uuid:bcc33d69-c4b2-49ef-b1cd-b604ceb2f6fa",
    "label": "Converted Declaration",
    "remark": "Auto-generated by AS3 Config Converter",
    "Common": {
        "class": "Tenant",
        "Shared": {
            "class": "Application",
            "template": "shared",
            "test_target": {
                "adaptive": false,
                "dscp": 0,
                "receive": "",
                "receiveDown": "",
                "send": "",
                "timeout": 3,
                "class": "Monitor",
                "monitorType": "tcp",
                "targetPort": 0,
                "transparent": false,
                "reverse": false
            }
        }
    }
}%

2. Observe the following error message once try to deploy first covnersion:

   {
   "code": 422,
   "errors": [
   "/Common/Shared/test_target/targetAddress: should match format \"f5ip\""
   ],
   "declarationFullId": "",
   "message": "declaration is invalid"
   }

   Second one result in port 0 (in fact all ports) instead of desired one.

Expected Behavior

Properly convert to target address and target port.

Actual Behavior

Wrong logic in conversion for wildcard IP and specific port given.

[sschadwick]

Issue forwarded to AS3 team: https://github.com/F5Networks/f5-appsvcs-extension/issues/528