search

f5devcentral / f5-azure-saca

Secure Azure Computing Architecture for DoD (SACA) - Notional Secure Cloud Computing Architecture (SCCA) Deployment
MIT License
26 stars 39 forks source link

Getting an error about missing variable #124

Closed sewalshmsft closed 3 years ago

sewalshmsft commented 3 years ago

Should this line use bigip_regkey instead of license for the variable declaration that is getting passed to the DO?

https://github.com/f5devcentral/f5-azure-saca/blob/7f369b9ee358dfbdfda72b7cceb71bfc1cefab35/three_tier/waf/bigip.tf#L374

The DO requires ${bigip_regKey} as an input for the variable, not ${license}.

https://github.com/Mikej81/f5-bigip-hardening-DO/blob/5f3563afabf730e3851a83734fdf18cb689b9c1c/dist/terraform/latest/byol_cluster_waf_tier.json#L12

Mikej81 commented 3 years ago

Patched in DO Repo. https://github.com/Mikej81/f5-bigip-hardening-DO/commit/5ae8236d60e5dbb8cd7f038999d3e66ad38046d2

sewalshmsft commented 3 years ago

These two lines in the firewall/bigip.tf use bigip_regkey, these will need updating too:

https://github.com/f5devcentral/f5-azure-saca/blob/7f369b9ee358dfbdfda72b7cceb71bfc1cefab35/three_tier/firewall/bigip.tf#L413

https://github.com/f5devcentral/f5-azure-saca/blob/7f369b9ee358dfbdfda72b7cceb71bfc1cefab35/three_tier/firewall/bigip.tf#L440

Mikej81 commented 3 years ago

patched in commit commit 4f2373caf673a1bdb88bbc7ad86bbde108e6d7ff