search

f5devcentral / f5-azure-saca

Secure Azure Computing Architecture for DoD (SACA) - Notional Secure Cloud Computing Architecture (SCCA) Deployment
MIT License
26 stars 39 forks source link

Commercial Cloud FQDN is hard-coded in the AzureDeploy.json #83

Closed Commochief closed 4 years ago

Commochief commented 4 years ago

I noticed that the commercial cloud is hard coded in mutliple places in the template which produces the wrong VM name when deploying the template to MAG. I deployed the 1 Tier file but the 3 Tier file also looks wrong.

Correct URL Name should be ‘cloudapp.usgovcloudapi.net’ instead of ‘cloudapp.azure.com’. Probably need to have a GovCloud check or parameter to adjust the name for commercial or govcloud depending on deployment scenario.

Files: https://github.com/f5devcentral/f5-azure-saca/blob/master/SACAv2/3NIC_1Tier_HA/azureDeploy.json https://github.com/f5devcentral/f5-azure-saca/blob/master/SACAv2/3NIC_3Tier_HA/azureDeploy.json

Mikej81 commented 4 years ago

These URL's are only used in via API failover, the current SACA design uses via LB failover. URLs have been updated in #84 and #85 via Kyle H at MS.