f5devcentral / f5-bigip-image-generator

Generate custom images for F5 BIG-IP.
Apache License 2.0
34 stars 20 forks source link

build AWS AMI with EngHF: tags shows values for base build and not EngHF #12

Closed amolari closed 4 years ago

amolari commented 4 years ago

Describe the bug Creating an image with a Hotfix (EngHF), without specifying any tags, some default tags will be automatically created. They do not reflect the build, as their values are from the image (base biuild) and not from the Hotfix. Tags:

To Reproduce Steps to reproduce the behavior: Generate an AMI to AWS with a base image and an EngHF.

Expected behavior A clear and concise description of what you expected to happen. Above Tags should have the value corresponding to the EngHF and not the base build

Additional context Add any other context about the problem here. Public Cloud AWS

kmaloney commented 4 years ago

Are you using the latest version of the Image Generator, v1.5 (released last week), or an earlier version?

I tried to repro this in v1.5, and the tags seem to reflect the EngHF version file. There were changes made in v1.5 to properly name EngHF images and check that the base image and EngHF image are compatible. These changes required unpacking the EngHF version file from the EngHF image. A side-effect of these changes is that the EngHF version file is used for tagging rather than the base image version file.

I confirmed that when I built an AWS image using Image Generator v1.4, that the behavior matches what you have described (tags reflect base image version file).

amolari commented 4 years ago

I had installed v1.4 a few days before v1.5 out. I've tested it and can confirm that v1.5 fixed the issue.