search

f5devcentral / f5-puppet

Puppet modules for F5 BIG-IP
Apache License 2.0
13 stars 27 forks source link

Fix f5_profileclientssl syntax error #65

Closed msmost closed 3 years ago

msmost commented 5 years ago

When using the f5_profileclientssl resource under the current release, the following error is produced because of incorrect syntax:

Could not autoload puppet/provider/f5_profileclientssl/rest: /opt/puppetlabs/puppet/cache/lib/puppet/provider/f5_profileclientssl/rest.rb:21: syntax error, unexpected tIDENTIFIER, expecting ')'

This PR should fix the issue @ericzji @hunner

nwea-seanmckinley commented 3 years ago

Is there any chance you guys can merge this? I'm a bit confused how such a simple pull request has been left open for like a year and 7 months, especially when it's such a straight forward fix.

nwea-seanmckinley commented 3 years ago

Is there any chance you guys can merge this? I'm a bit confused how such a simple pull request has been left open for like a year and 7 months, especially when it's such a straight forward fix.

actually looks like the comma was added here https://github.com/f5devcentral/f5-puppet/commit/59b7ee45769b968733e4976a276af03b0383e7dc

Is there a way a new tag can be cut for this module then? 1.9.2 perhaps?