f5devcentral / f5-waf-policy-editor

Apache License 2.0
26 stars 14 forks source link

[enhancement] Sample help text for each fields #29

Open shubhammishra9 opened 3 years ago

shubhammishra9 commented 3 years ago

Observed keeping invalid values in fields are allowed, but when download and kept in nginx conf. file hitting issues. Dummy samples or some validations can be given in UI for each available options.

Error message for policy mentioned in attached image:

Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: { Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: "completed_successfully" : false, Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: "error_message" : "Failed to import Policy 'policy_name' from '/etc/app_protect/conf/waf.json': Unknown Open API Content format.", Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: "error_line_number" : 23 Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: } Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal nginx[1832]: nginx: [error] APP_PROTECT { "event": "configuration_load_failure", "software_version": "3.639.0", "error_message":"Failed to import Policy 'policy_name' from '/etc/app_protect/conf/waf.json': Unknown Open API Content format.","completed_successfully":false,"error_line_number":23} Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal systemd[1]: nginx.service: control process exited, code=exited status=1 Sep 16 07:42:45 ip-172-31-21-251.ap-south-1.compute.internal systemd[1]: Failed to start NGINX Plus - high performance web server.

htext

464d41 commented 3 years ago

I see two items here:

shubhammishra9 commented 2 years ago

Missing link format validation in new UI as well m2

Error Message: Dec 22 07:48:14 ip-172-31-20-26.ap-south-1.compute.internal nginx[1703]: { Dec 22 07:48:14 ip-172-31-20-26.ap-south-1.compute.internal nginx[1703]: "completed_successfully" : false, Dec 22 07:48:14 ip-172-31-20-26.ap-south-1.compute.internal nginx[1703]: "error_message" : "Failed to import Policy '/etc/app_protect/conf/waf-1639385507591.json' from '/etc/app_protect/conf/waf-1639385507591.json': Wrong link format, should be 'file:///FILE_NAME' or 'http(s)://DOMAIN_NAME/FILE_NAME'", Dec 22 07:48:14 ip-172-31-20-26.ap-south-1.compute.internal nginx[1703]: "error_line_number" : 19 Dec 22 07:48:14 ip-172-31-20-26.ap-south-1.compute.internal nginx[1703]: }