search

f5devcentral / terraform-provider-bigip-old

This Repo is Deprecated please refer to https://github.com/terraform-providers/terraform-provider-bigip Provider is Published !
Mozilla Public License 2.0
32 stars 15 forks source link

Fixing Read method in VLAN and SelfIP resources #126

Closed dannyk81 closed 6 years ago

dannyk81 commented 6 years ago

@scshitole This PR refactors the vlan and selfip resources:

1) vlan resource Create method now uses partial sets, since creating the vlan and adding the interfaces are two separate API calls and without partial set may leave the state broken.

2) vlan resource Read now retrieves all attributes, including the interfaces via a new method in go-bigip.

NOTE: this change requires go-bigip PR https://github.com/f5devcentral/go-bigip/pull/18 to be merged and vendoring updated in this branch 🚀

3) selfip resource Read now retrieves all attributes and updates them in state correctly.

dannyk81 commented 6 years ago

@scshitole Travis tests are failing because of missing dependency with https://github.com/f5devcentral/go-bigip/pull/18

scshitole commented 6 years ago

@dannyk81 Yesterday the repo got published the new repo is https://github.com/terraform-providers/terraform-provider-bigip you can open a PR on the above repo

dannyk81 commented 6 years ago

@scshitole wow! congrats 😄

Ok, I'll move my PRs to the new repo.

dannyk81 commented 6 years ago

@scshitole could you merge https://github.com/f5devcentral/go-bigip/pull/18 though? as this is needed for this PR anyway.

Thanks!!!

dannyk81 commented 6 years ago

merged in the official provider repo