search

f5devcentral / terraform-provider-bigip-old

This Repo is Deprecated please refer to https://github.com/terraform-providers/terraform-provider-bigip Provider is Published !
Mozilla Public License 2.0
32 stars 15 forks source link

produce binaries for releases using goreleaser #86

Closed tkellen closed 6 years ago

tkellen commented 6 years ago

Thank you so much for making this project available--I'm really excited about the prospect of using it!

As a first time user, I found myself wishing that binary releases were available for operators who don't have a background with the go ecosystem. In the hope of establishing a workflow for that, I've implemented a few small changes to enable this.

Here is a quick summary (basically a recounting of the commit messages):

  1. Switch to using the official go vendoring tool, dep.
  2. Incorporate the project goreleaser to make building and publishing cross-compiled binaries to github exceptionally easy.

As a concrete example of what this enables, please see the 0.13 release on my fork: https://github.com/tkellen/terraform-provider-bigip/releases

That was generated by simply making a tag and running goreleaser locally.

I would be happy to take this PR a bit further (for example, adding support for cutting releases out of CI using Travis, adjusting the Makefile and updating the README), but before I put any more effort into it, I'd love to know what the maintainers of this project feel about the approach.

Looking forward to hearing your thoughts!

jakauppila commented 6 years ago

I'd be all for, makes it a lot easier for people to get up and running.

tkellen commented 6 years ago

Thanks for the merge on the upstream repo @scshitole! I've updated the vendor dependencies (dep ensure -update). Things are still building but I'm unclear at present how to run tests to ensure nothing has broken.

Since it seems like you're in favor of this change, should I go ahead with the README updates and travis integration?

scshitole commented 6 years ago

@tkellen I can run tests locally and see if anything is broken else we have to back off PR