Closed samualblair closed 1 week ago
samualblair
commented
4 months ago I'm thinking there must be some parameter in my NS config file that is not mapping well with the new code versions, because the "Lead Example / Test NS Config" seems to work as expected.
samualblair
commented
4 months ago Looks like I found the problem, the monitor section is failing. When I comment out this section of ns2FastParams.js I am able to convert.
I assume this means in version 1.10.1 and 1.10.0 any config with monitors would fail, without would work.
I also assume this means monitors are not being parsed and added to the converted code (it may already be documented as a limitation, but I haven't spent enough time to tell yet).
nsFastJson.monitors = nsFastJson === null || nsFastJson === void 0 ? void 0 : nsFastJson.monitors.map(monitor => {
// todo: get details for new mapping
return monitor;
});
return the new paramsAnyway, short of completing the pending work in this section, I would suggest this section be commented out for the time being.
samualblair
commented
4 months ago Offering a pull request for the workaround, 37
Better fix found.
samualblair
commented
4 months ago Canceling that, found the issue after a few more minutes of looking.
The object nsFastJson was missing the monitors.
So this:
const nsFastJson = {
tenant_name: nsApp.name,
app_name: nsApp.name,
type: nsApp.type,
protocol: nsApp.protocol,
virtual_address: nsApp.ipAddress,
virtual_port: nsApp.port === '*' ? '0' : nsApp.port,
pool_members: []
};Should be:
const nsFastJson = {
tenant_name: nsApp.name,
app_name: nsApp.name,
type: nsApp.type,
protocol: nsApp.protocol,
virtual_address: nsApp.ipAddress,
virtual_port: nsApp.port === '*' ? '0' : nsApp.port,
pool_members: [],
monitors: []
};This seems to fix the issue and not prevent the monitors from coming over.
samualblair
commented
4 months ago Offering a pull request with fix , 38
DumpySquare
commented
1 week ago this fix will in the pending v1.11.0 release
Describe the bug A clear and concise description of what the bug is.
TypeError when attempting to explore JSON (and therefore convert to anything) running Version >= 10.10.0 Unable to explore JSON (and therefore convert to anything) running Version 1.10.1 and 10.10.0 while working with 1.8
To Reproduce Steps to reproduce the behavior:
Expected behavior Expect a json to be generated and displayed in a new editor tab/window.
Screenshots See logs below.
Desktop (please complete the following information):
OS: macOS 14.5
VS Code: Version: 1.89.1 Commit: dc96b837cf6bb4af9cd736aa3af08cf8279f7685 Date: 2024-05-07T05:14:32.757Z (2 wks ago) Electron: 28.2.8 ElectronBuildId: 27744544 Chromium: 120.0.6099.291 Node.js: 18.18.2 V8: 12.0.267.19-electron.0 OS: Darwin arm64 23.5.0
F5 Flipper 10.10.1 and 10.10.0 have symptoms.
F5 Flipper 10.8.0 Does not have the symptom.