f5vmr / SVXLink-Dash-V2

7 stars 3 forks source link

DTMF Buttons sometimes not shown #5

Open dl1nux opened 4 months ago

dl1nux commented 4 months ago

The dashboard code has an issue what has been inherited from the original versions. The dashboard distinguishes between "local" and "remote" addresses when viewing the dashboard. "Local" IP addresses will show the DTMF buttons and an input field. Viewing from remote adresses will not show them.

The definition of the "local" adresses is a little bit stupid (not your fault Chris) and should be corrected in .../include/buttons.php

Wrong definition! : $net1= cidr_match($ip,"192.168.0.0/8"); $net2= cidr_match($ip,"192.175.43.91/8"); $net3= cidr_match($ip,"127.0.0.0/8"); $net4= cidr_match($ip,"192.168.1.0/8"); $net5 = cidr_match($ip, "192.168.1.254/8");

Correct definition of private adresses: $net1= cidr_match($ip,"192.168.0.0/16"); $net2= cidr_match($ip,"10.0.0.0/8"); $net3= cidr_match($ip,"127.0.0.0/8"); $net4= cidr_match($ip,"172.16.0.0/12"); $net5= cidr_match($ip,"169.254.0.0/16");

After that change all can see the buttons when viewing the dashboard locally. It can be adapted when using special networks.

73 Attila DL1NUX

dl1nux commented 4 months ago

And as addition, you are writing in the README:

"Below the footer menu you will see a dtmf control facility. The D buttons are not yet programmed, and will need to correspond with the Macros in svxlink.conf so you will need to self-edit the dtmf.php file in your dashboard configuration and the macros in svxlink.conf."

It's only neccessary to edit config.inc.php to personalize the DTMF buttons, for example:

define("KEY1", array(' Hassberge ','9197475#','green')); define("KEY2", array(' Franken ','9126284#','orange')); define("KEY3", array(' Bayern ','912628#','orange')); define("KEY4", array(' RAMSES ','9165075#','orange')); define("KEY5", array(' Papagei', '1#','purple')); define("KEY6", array(' Echolink ','2#','purple')); define("KEY7", array(' EL DB0UC ','2#96450#','purple')); define("KEY8", array(' EL Echotest ','2#9999#','blue')); define("KEY9", array(' Trennen ','##','blue')); define("KEY10", array(' Status ','9*#','red'));

No need to edit macros or dtmf.php.

f5vmr commented 4 months ago

To be honest, these should be only for the local user. I have not configured any of mine for anything but local interaction. I expect there will be likely some people playing with this if the dashboard is exposed on a global address. I’m still working on a better edit scheme on another repo at the moment. I’ll post that when It’s complete. The DTMF part was made by SP2ONG and his associates.

Chris

On 29 Apr 2024, at 21:00, Attila Kocis @.***> wrote:

The dashboard code has an issue what has been inherited from the original versions. The dashboard distinguishes between "local" and "remote" addresses when showing the dashboard. "Local" IP Adresses will show the DTMF Buttons an Input field. Remote adresses not.

The definition of the "local" adresses is a little bit stupid (not your fault Chris) and should be corrected in .../include/buttons.php

Wrong definition! : $net1= cidr_match($ip,"192.168.0.0/8"); $net2= cidr_match($ip,"192.175.43.91/8"); $net3= cidr_match($ip,"127.0.0.0/8"); $net4= cidr_match($ip,"192.168.1.0/8"); $net5 = cidr_match($ip, "192.168.1.254/8");

Correct definition of private adresses: $net1= cidr_match($ip,"192.168.0.0/16"); $net2= cidr_match($ip,"10.0.0.0/8"); $net3= cidr_match($ip,"127.0.0.0/8"); $net4= cidr_match($ip,"172.16.0.0/12"); $net5= cidr_match($ip,"169.254.0.0/16");

After that change all can see the buttons when viewing the dashboard locally. It can be adapted when using special networks.

73 Attila DL1NUX

— Reply to this email directly, view it on GitHub https://github.com/f5vmr/SVXLink-Dash-V2/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACAKA5EYE65LTQTXRPBEMNDY72RGPAVCNFSM6AAAAABG66WATCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DSOBVHEZTMNY. You are receiving this because you are subscribed to this thread.

dl1nux commented 4 months ago

Yes, the buttons are only for local usage. But they can't be used if the local network does not match to the hard coded networks, which are mostly incorrect. Here we had several users who couldnt use the buttons (locally!) because they have other network addresses. It's just a hint, because most people would not know why they cant see the buttons.