Never hard-code feature-specific include in mk/generic.mk

f9micro / f9-kernel

An efficient and secure microkernel built for ARM Cortex-M cores, inspired by L4

Other

683 stars 145 forks source link

Never hard-code feature-specific include in mk/generic.mk #33

Closed jserv closed 11 years ago

jserv commented 11 years ago

At present, mk/generic.mk includes mk/rules/symmap.mk directly, that is regarded as unexpected usage for build system since its name implies the generic operations.

We should include some make rule definitions only when the feature is matching. To make it better, it is straightforward to scan the configurations in directory mk/rules first and then specify the inclusion.

arcbbb commented 11 years ago

will this patch 70e7770 be ok?

jserv commented 11 years ago

Excellent! Thanks for this patch. Merged.