search

fAuernigg / esp32-baresip-client

19 stars 6 forks source link

esp32phone as a submodule #1

Open sosaucily opened 4 years ago

sosaucily commented 4 years ago

Hi! This is a cool project, I've seen enough people chatting about something like this online, so I'm happy to see you took it on. I'm interested in using this, and helping out a bit along the way as I can as well.

Would you be open to organizing this in such a way that the esp32phone / sipphone module could itself be a stand-along submodule that can be imported into a project? Then there would be a project like this, which included all the code to run and test the esp32baresip phone (an example of how to use it), and another module that people can actually import directly.

Thanks!

fAuernigg commented 4 years ago

Thanks for your feedback. I can try to make a library with an interface compatible with esp-idf out of this project including an example/demo. Is this what you mean with submodule?

What do you mean with import? Do you mean import into arduino ide? My approach was to build it standalone (easiest way with the included docker definition) . Anyhow I'm using arduino libraries via "arduino-esp32" because of it's good esp abstraction layer. A library for arduino ide would be possible of course.

sosaucily commented 4 years ago

Well now to use the important files I would probably copy sipphone.cpp over into my project, along with a few other files you wrote. I would also need to import the various submodules you need, set to the right branch, etc. So a module with an interface for instantiating and using a sipphone from other projects, and being able to cleanly do updates to it over time, etc. So if it was itself a submodule that would be upgraded (same we we upgrade ESP-IDF sometimes) would be great.

At least, I think this could make sense. I don't use ESP-Adruino in my project, so it's been taking me some time to get everything working together correctly. So I may not be aware of the best way to do some of these things.

fAuernigg commented 4 years ago

Ok now I understand your way of integration. A git submodule inside your project makes sense and would be integrated into your esp-idf project as a component having a defined interface in a sip phone header file. I will add such project soon.

sosaucily commented 4 years ago

Awesome! Espressif provides a sip client but it's closed-source and doesn't offer the same feature set of baresip 👍

sosaucily commented 4 years ago

Btw, do you think the custom branches by cspiel1 (esp32 branches for re and baresip) will get PR'd into the original repos?

cspiel1 commented 4 years ago

On Mon 02.12.19 02:32, Jesse Smith wrote:

Btw, do you think the custom branches by cspiel1 (esp32 branches for re and baresip) will get PR'd into the original repos?

These branches are very specific for esp32. They contain these changes compared to mainline:

We (mrxa13 and me) will provide soon a repository on github of an esp-idf component for baresip (and one for libre) that contains the esp32 specific changes as patches.

regards,c

sosaucily commented 4 years ago

That's awesome, very exciting to hear about this project. Actually seems like, with some legwork, each of the differences you mention on your custom branches can probably be integrated into the main repo. I'm happy to help out with that as best I can, probably once things are moved over to that new repo you mention.

sosaucily commented 4 years ago

Another question, why is this client pegged to v3.2 of the esp-idf? I try to compile with stable AKA release/v3.3 but it throws some errors compiling the SoC module.