search

fNIRS / snirf

SNIRF Format Specification
http://fnirs.org/resources/software/snirf/
Other
59 stars 34 forks source link

ready to release? #10

Closed dboas closed 5 years ago

dboas commented 5 years ago

@fangq and @jayd1860 , what more is needed to be completed to release the spec? Maybe all the issues except for the streaming one? Should we invite all the supporters to this project and give them a little more time to comment? Anything else? @dboas

fangq commented 5 years ago

hi David, we haven't announced this repository yet, we should get more feedback. but feature wise, I think it looks quite good.

jayd1860 commented 5 years ago

David and Qianqian,

Had a question about the stim structure. We now have

stim(n).name stim(n).data

stim(n).data is a 3 column array where each row corresponds to a stimulus trial and the three columns indicate [starttime duration value].

In Homer2, users can manually reject/toggle stims and we indicate this with various non-zero and non-one values. Assuming we want to preserve this functionality in SNIRF and Homer3, do we use the last column for this purpose?

I didn't see any description in the Spec about the last column. Should we add a short description of it's use?

dboas commented 5 years ago

Qianqian, should I go ahead and announce it? To announce it, should I email the small group of people and tell them to come to GitHub at https://github.com/fNIRS/snirf/ ? I would email them at snirf at fnirs.irg

Jay, I moved your comment to a new issue.

fangq commented 5 years ago

let's finish a few changes first: 1) add the contributor list, 2) add streaming support (pull #11), and I will move landmark/landmarkName to sd.

after that, I will create a RFC commit and update the README, then we can invite people to comment on a clean version.

fangq commented 5 years ago

one more minor change before release - I would also remove the two lines regarding the "last update dates", since now it is version controlled by git.

fangq commented 5 years ago

@dboas and @jayd1860, I created a clean copy of the specification, should be ready for user comments.

do you want to announce it to the mailing list?

dboas commented 5 years ago

Yeah, I will mention it to the mail list. Thanks Qianqian! David

From: Qianqian Fang notifications@github.com Reply-To: fNIRS/snirf reply@reply.github.com Date: Wednesday, December 5, 2018 at 12:18 PM To: fNIRS/snirf snirf@noreply.github.com Cc: "Boas, David" dboas@bu.edu, Mention mention@noreply.github.com Subject: Re: [fNIRS/snirf] ready to release? (#10)

@dboashttps://github.com/dboas and @jayd1860https://github.com/jayd1860, I created a clean copy of the specificationhttps://github.com/fNIRS/snirf/commit/88baa2a2ed3347e868ec184b9daa4b357ddbbfd1, should be ready for user comments.

do you want to announce it to the mailing list?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/fNIRS/snirf/issues/10#issuecomment-444566644, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Acon9FoEQCvh7Mnx_S0BQq34j9hTc431ks5u1_8zgaJpZM4Y4QqS.