fNIRS / snirf

SNIRF Format Specification
http://fnirs.org/resources/software/snirf/
Other
59 stars 34 forks source link

DNM: Remove 10-20 from landmark description #117

Open rob-luke opened 2 years ago

rob-luke commented 2 years ago

This PR tries to clarify the terminology used in landmarkLabels. It is in follow up to an email between me and the BUNPC.

First, the old text referred to probe.landmark, which does not exist. I assume this was meant to refer to probe.landmarkPos2D and probe.landmarkPos3D, so I added probe.landmarkPos to refer to both 2 and 3D.

Second, I make a change to the landmarkLabels text as I believe it conflated "landmarks" and "standardized placement systems".

Landmarks are positions on the skull that are used to guide sensor placement. E.g. Nasion, Inion, LPA, RPA Standardized placement systems specify locations on the head to place sensors. E.g. 10-20

[1] R. Oostenveld and P. Praamstra. The five percent electrode system for high-resolution EEG and ERP measurements. Clin Neurophysiol, 112:713-719, 2001. [2] Fieldtrip [3] BIDS [4] MNE

rob-luke commented 2 years ago

Do not merge this. I have discussed on the phone with David, and will try some things locally and then make fresh suggestions here.

Horschig commented 1 year ago

Any update on this?