search

fNIRS / snirf

SNIRF Format Specification
http://fnirs.org/resources/software/snirf/
Other
57 stars 33 forks source link

Added ICNNA to snirf supporting software list #139

Closed forihuelaespina closed 3 months ago

forihuelaespina commented 6 months ago

Added ICNNA to snirf supporting software list

Horschig commented 6 months ago

@forihuelaespina can you please add forihuelaespina to https://github.com/fNIRS/snirf/blob/master/.github/workflows/wordlist.txt ? Thanks!

dboas commented 5 months ago

@forihuelaespina can you make the change to the wordlist so that your pull request passes the spell check. This pull request is in limbo until you do that.

samuelpowell commented 4 months ago

@forihuelaespina please could you update as requested by @dboas then we will get this merged?

forihuelaespina commented 4 months ago

With my apologies for the delay. This has now been attended.

samuelpowell commented 4 months ago

@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).

Disregard above. I do not know why this is not passing, any ideas?

Horschig commented 4 months ago

~@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).~

Disregard above. I do not know why this is not passing, any ideas?

Not sure, the trailing white space is the only thing that would come to mind also.

forihuelaespina commented 4 months ago

I've now removed the trailing space but left the trailing lines just in case. Whether this is what is preventing the update or not, I do not know.

samuelpowell commented 4 months ago

@Horschig can you approve review also?