Add dataOffset field - Githubissues

fNIRS / snirf

SNIRF Format Specification

http://fnirs.org/resources/software/snirf/

Other

57 stars 33 forks source link

Add dataOffset field #143

Closed rob-luke closed 2 months ago

rob-luke commented 3 months ago

As part of understanding the implications of the simpler proposal from @dboas in #126, I wrote out how it might be implemented. (I always lean into the simple solution first and understand its drawbacks before moving to the more complex option).

Will this resolve the issue raised by @julien-dubois-k ?
Will it have any downstream undesired effects?
Would the more complex proposal solve any real-world issues in current or next-gen commercial hardware?

samuelpowell commented 3 months ago

Confirmed as a 'good idea' in meeting of May 24, @rob-luke to convert to full PR for review.

julien-dubois-k commented 2 months ago

This seems to address the issue, and does so very simply. Anything preventing this from being completed/merged?

samuelpowell commented 2 months ago

@julien-dubois-k the intention is to proceed with this as soon as possible, @rob-luke I am happy to review when you are ready.

rob-luke commented 2 months ago

This seems to address the issue, and does so very simply. Great to hear, thanks for reviewing @julien-dubois-k Lets get this issue closed off!

@samuelpowell I've removed the draft status and it's ready for review