Correct dataTypeIndex ambiguous definition - Githubissues

fNIRS / snirf

SNIRF Format Specification

http://fnirs.org/resources/software/snirf/

Other

57 stars 33 forks source link

Correct dataTypeIndex ambiguous definition #152

Closed HanBnrd closed 1 month ago

HanBnrd commented 1 month ago

Fixes #87

Corrects the dataTypeIndex ambiguous definition to clarify that it is indeed an integer (and not a numeric 1-D array).

Elements that have also been checked for coherence with this PR:

[x] dataType
[x] dataTypeLabel
[x] detectorModuleIndex
[x] probe/wavelengths
[x] probe/frequencies
[x] probe/timeDelays
[x] probe/timeDelayWidths
[x] probe/momentOrders
[x] probe/correlationTimeDelays
[x] probe/correlationTimeDelayWidths
[x] Appendix

dboas commented 1 month ago

@samuelpowell this has two approvals. Do you want to merge it?