fNIRS / snirf

SNIRF Format Specification
http://fnirs.org/resources/software/snirf/
Other
59 stars 34 forks source link

add OBELAB to supported vendors #159

Closed JMKIM-OBELAB closed 1 month ago

JMKIM-OBELAB commented 2 months ago

Dear Collaborators,

We have recently released measurement tool and analysis tool fully compatible to snirf format using NIRSIT system.

I added OBELAB as a vendor supporting snirf data format.

If there's further information needed, I am happy support.

HanBnrd commented 2 months ago

Thank you @JMKIM-OBELAB.

I've updated the word list to pass spell check tests.

@fNIRS/snirf_maintainers, do we need to test this with the validator?

Horschig commented 1 month ago

Thank you @JMKIM-OBELAB.

I've updated the word list to pass spell check tests.

@fNIRS/snirf_maintainers, do we need to test this with the validator?

Do you mean testing their OBELAB files with the validator? No, we never did this with any other vendor, also not with us.

Or do you mean checking if the repo is still intact? The spellcheck action should have checked that. So I think everything is fine here.

HanBnrd commented 1 month ago

Yes, I was wondering if we should check vendor files before adding as supported in the specs.

Alright sounds good then.

Horschig commented 1 month ago

I think it's the vendor's responsibility to check whether their files really conform to the specs, it should not be our task (also e.g. in our case there are 100s of possible file types, like single device, multiple devices, with aux channels, without, etc, so it's a Herculean task without known device details).