Closed fangq closed 5 years ago
hi @dboas, upon listing all the subfields in types, I realized that data(idx).ml is actually a container type, and has both integer and floating point subfields.
just merged the changes I made over the past few weeks, commit 84e689844fd101951c5d1cf807ec7f1248d9738b addressed this issue. closing.
hi @dboas and @jayd1860, I sent you an email on some updates about 2 weeks ago, but I know you guys were busy with the fnirs course. I just went ahead and merged these changes with the master repository, you can see the accummulative changes in pull request https://github.com/fNIRS/snirf/pull/6
some of the major updates include
Please take a look, and let me know if you are ok with these changes.
Hi Qianqian,
I'm on vacation until Nov 21. I will take a look as soon as I'm back and get back to you with what I think.
Jay
From: Qianqian Fang notifications@github.com Sent: Thursday, November 15, 2018 12:24:55 PM To: fNIRS/snirf Cc: Dubb, Jay; Mention Subject: Re: [fNIRS/snirf] Specify data types, endianness and maximum string length (#4)
hi @dboashttps://github.com/dboas and @jayd1860https://github.com/jayd1860, I sent you an email on some updates about 2 weeks ago, but I know you guys were busy with the fnirs course. I just went ahead and merged these changes with the master repository, you can see the accummulative changes in pull request #6https://github.com/fNIRS/snirf/pull/6
some of the major updates include
Please take a look, and let me know if you are ok with these changes.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/fNIRS/snirf/issues/4#issuecomment-439121372, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AqMamnH6-x8-Ms0-ngwbf7jjjP3wWxHmks5uvaNngaJpZM4XceZg.
here is a list of sub-fields and their preferred data types:
Container type (struct or cell-like data in MATLAB):
Floating-point types (double as default - should we also support single-precision?):
Integer types:
String types: