refactor: set redirect url instead of making it with bundle identifier

fa-fifi / keycloak_wrapper

Keycloak Single Sign-On (SSO) authentication package for Flutter framework.

https://pub.dev/packages/keycloak_wrapper

BSD 3-Clause "New" or "Revised" License

12 stars 11 forks source link

refactor: set redirect url instead of making it with bundle identifier #27

Closed MarinCouderc closed 9 months ago

fa-fifi commented 9 months ago

Hi @MarinCouderc 👋

LGTM but I think the redirectUrl parameter should be optional and we should set the default value to $_bundleIdentifier://login-callback in case there is no redirectUrl provided. Mostly for simple Keycloak app, there is no need for a custom redirectUrl.

What do u think?