search

faa-swim / swim-discovery-service

1 stars 1 forks source link

Difference between the schema and the implementation #22

Open TianYungang opened 2 years ago

TianYungang commented 2 years ago

  1. When access the GetDiscoveryService operation, the "point-of-contact" obtained from KAC and FAA is an object, while in https://discovery.swim.aero/sdm-j/1.0.1/organization.json, "point-of-contact" is defined as array. 图片1

  2. When access the GetServices operation, the "service-availability-status" and the "interface-type" obtained from KAC and FAA are array, while in https://github.com/faa-swim/swim-discovery-service/blob/main/sds/1.0.1/services.json, "service-availability-status" and "interface-type" are defined as object. 图片2 图片3

  3. When access the GetService operation, the "service-id" is missing in the response of FAA, but it is required in https://github.com/faa-swim/swim-discovery-service/blob/main/sdm-j/1.0.1/service-description.json 图片4

  4. what the difference between "/service-description" definded in https://github.com/faa-swim/swim-discovery-service/blob/main/sds/1.0.1/sds.json and "/services/{service-id} or {acronym}" implemented in the SDS instance. Whether the "/service-description" will be removed.

cinglefield commented 1 year ago

Mr. Tian,

Thank you for your thorough review of the v1.0.1 schemas located on GitHub against the current implementations. Wen has analyzed the schemas versus the SDCM and SDS Specification requirements and verified that the schemas are correct.

You are correct in that the SMXS implementations should be updated to match the schemas.

I will be updating this issue with the FAA SMXS corrected implementations prior to pushing updated code out to the NSRR. I added Mr. Lu to this issue as well, Mr. Han is already listed as an assignee. I apologize for any rework the incorrect implementations have caused.

Caroline