search

faaez / capiq-python

Thin Python client for the CapIQ REST API
MIT License
35 stars 25 forks source link

Lots of changes #6

Closed guydmann closed 7 years ago

guydmann commented 7 years ago

I added tests, request caching, improved data and error handling, made the package installable with pip, moved the credentials out of the settings file so that the module can be used without modifying any code in it, added a return mapping functionality to allow requesting the same mnemonic with different properties and be able to easily distinguish them in the returned object, and wrote a script to easily run the unit test coverage. I also moved your original tests into the capiq/tests/manual directory without a init.py file there so that those tests are not run by the unit test script.

Also have you considered adding a LICENSE file?

faaez commented 7 years ago

This is awesome @guydmann ! Thanks :) Good suggestion re: adding license.

guydmann commented 7 years ago

Thanks, I'm glad you like the change. It was great to have a good jumping off point.

guydmann commented 7 years ago

oh you may want to update the documentation to reference this repo instead of my fork.