search

faaiz-space / hut-calci

This project is for implementing different animations with which users can interact, It has a Calculator which has some cool features but needing more for others to get benifits.
15 stars 13 forks source link

Add validation to prevent letter input #33

Closed MasterReach1 closed 2 years ago

MasterReach1 commented 2 years ago

I have added regex validation to the calculator input to prevent keyboard letter input. Please assign this issue to me and I will submit a PR

faaiz-space commented 2 years ago

I have added regex validation to the calculator input to prevent keyboard letter input. Please assign this issue to me and I will submit a PR

Yeah @MasterReach1 we are glad to see your effort and we are assigning this issue to you.

Another thing is if you can add the functionality on keypress 'Enter' to evaluate the result which is currently being done only on clicking the "=" sign.

You can raise another issue for it.✅

MasterReach1 commented 2 years ago

I have added regex validation to the calculator input to prevent keyboard letter input. Please assign this issue to me and I will submit a PR

Yeah @MasterReach1 we are glad to see your effort and we are assigning this issue to you.

Another thing is if you can add the functionality on keypress 'Enter' to evaluate the result which is currently being done only on clicking the "=" sign.

You can raise another issue for it.✅

I certainly will. I noticed this feature was lacking and am working on a solution now. Thanks!

faaiz-space commented 2 years ago

Respective PR is merged