faameunier / tk-chrome

Tabby (aka project tabkiller) is a Chrome extension that aims at automatically deleting all your useless tabs.
https://www.tabby.us/
0 stars 0 forks source link

Elements added in manifest for Firefox trigger error in chrome #100

Closed MerlinLaffitte closed 4 years ago

MerlinLaffitte commented 4 years ago

What

image

How

Possible solution could be two different manifests triggered by npm run build-prod-ff and npm run build prod-chrome or do we need to use these elements at all for FF?

faameunier commented 4 years ago

j'en avais parlé sur WA, given it is a warning I would ignore, unless you want to maintain 1 manifest per browser and have a specific build for each

MerlinLaffitte commented 4 years ago

Ok do we know how Chrome takes into account warnings in the code for the SEO?

faameunier commented 4 years ago

No idea, but I'd say to ignore it for the moment. If we lose some ranks we'll decide what to do.