tabby closes the tab I want to go on

[faameunier]

Describe the current situation On firefox during testing, I realized that when clicking on the poorest ranked tab, tabby might kill it while I am clicking on it.

Reproduction steps If we can't reproduce, it is almost impossible to solve!

1. Open 6 tabs in a row
2. Spend 30sec on each tab one after the other BUT the last one
3. Do so for 5 minutes
4. Stop doing anything
5. Wait 5 minutes
6. click on the tab you have never been to
7. The tab is deleted and you end up on another one

Expected behavior tabby should wait for the new tab to be selected before killing anything

Screenshots N/A

System:

• OS: Win10
• Browser: firefox
• tabby version 1.1.0

[faameunier]

Tested on Chrome : no bug there, Chrome blocks the tab deletion.

definitely happens on Firefox.

[faameunier]

idea: edit the queue. Create a cancellable promise that delays the subsequent end events.

when enqueue is called, cancel the promise always

on dequeue

• if the queue is not empty, and not working do nothing
• when queue is empty,launch the cancellable promise, store the cancel callback -- run subsequent end queue events if the promise resolves -- if the promise rejects catch silently

implementation example : article