search

faameunier / tk-chrome

Tabby (aka project tabkiller) is a Chrome extension that aims at automatically deleting all your useless tabs.
https://www.tabby.us/
0 stars 0 forks source link

[Front-end] changesClosedHistory condition might lead to runtime weird stuff #25

Closed faameunier closed 4 years ago

faameunier commented 4 years ago

Line 33 in Home component

            const changesClosedHistory = changes[CLOSED_HISTORY];
            if (changesClosedHistory &&
                changesClosedHistory['newValue'].length !== changesClosedHistory['oldValue'].length){

@faameunier I would remove the condition on length? maybe for some weird edge cases (really badly timed actions) the closedHistory can change with same size? The perf improvement here is negligible. wdyt ?

@MerlinLaffitte MerlinLaffitte 27 minutes ago Author Mmh agreed ! I did remove it in the Settings so this is on the point

MerlinLaffitte commented 4 years ago

This was handled in the last push