When opening the popup on Fefe's computer the loading of popup can sometimes take more than 2sec

faameunier / tk-chrome

Tabby (aka project tabkiller) is a Chrome extension that aims at automatically deleting all your useless tabs.

https://www.tabby.us/

0 stars 0 forks source link

Closed MerlinLaffitte closed 4 years ago

MerlinLaffitte commented 4 years ago

Apparently when Fefe is not logged in Uber website verify his identity when retrieving the icons at each icon maybe. Because the first render seems to wait for a correct display and the termination of all promises (whereas it is not the case when coming from the settings), it takes multiple seconds to go over the full list.

Make the first load of the list independant from the rendering process maybe in order to not wait for the icons and display default icons?

faameunier commented 4 years ago

faameunier commented 4 years ago

See commit c545160, should be solved as long as we have a reasonable wait time in the config file. 200ms is too short, 400ms a bit slow.

Let's see if this issue comes up again