Closed heisenbol closed 4 years ago
Imagine a feed link that has url parameters. Ampersands in this case have to be encoded. & has to be & in the url. For example an article with link tag https://www.domain.com/index.php?paramname1=a&paramname2=b
If the ampersand is not encoded, it would not be a valid RSS feed.
The Simplepie get_link() method returns the url as is. This is used in the LinkViewHelper.
The fluid templates encode the link from the viewhelper. The above example would result in the following HTML markup, which is wrong https://www.domain.com/index.php?paramname1=a&paramname2=b Notice & becoming &
The proposed change passes the Simplepie link through htmlspecialchars_decode before returning it to the fluid template.
Imagine a feed link that has url parameters. Ampersands in this case have to be encoded. & has to be & in the url. For example an article with link tag https://www.domain.com/index.php?paramname1=a&paramname2=b
If the ampersand is not encoded, it would not be a valid RSS feed.
The Simplepie get_link() method returns the url as is. This is used in the LinkViewHelper.
The fluid templates encode the link from the viewhelper. The above example would result in the following HTML markup, which is wrong https://www.domain.com/index.php?paramname1=a&paramname2=b Notice & becoming &
The proposed change passes the Simplepie link through htmlspecialchars_decode before returning it to the fluid template.