search

fabbricadigitale / paper-chip

A chip web component made with Polymer 2 following Material Design guidelines
http://webcomponents.org/element/fabbricadigitale/paper-chip
MIT License
31 stars 16 forks source link

Add suffix slot #57

Closed vivetech closed 6 years ago

vivetech commented 7 years ago

The suffix slot makes it possible to add something useful like a dropdown.

leodido commented 7 years ago

Hi @vivetech thanks for contributing your ideas and code.

Anyway we are working on a complete refactoring and improvement (including the presence of suffix, for example) of the element.

You can find it in the feature/issue-50 branch (soon to be merged into the development branch).

So it'd be appreciable if you can contribute the dispatching of events - eg., chip-added, chip-removed - with a new PR towards the current develop. Furthermore please follow our contributing guide.

Thanks a lot!

~l.

leogr commented 6 years ago

chip-added and chip-removed had been added into #58 , also suffix should be work there.

leogr commented 6 years ago

Fixed by #58