search

fabbricadigitale / paper-chip

A chip web component made with Polymer 2 following Material Design guidelines
http://webcomponents.org/element/fabbricadigitale/paper-chip
MIT License
31 stars 16 forks source link

Added icon support to embedded paper-chips #68

Closed KeithHenry closed 6 years ago

KeithHenry commented 6 years ago

Following on from https://github.com/fabbricadigitale/paper-chip/pull/63 applied same changes to develop branch

leodido commented 6 years ago

Tomorrow I'll be busy with other things.

I cc the team @fabbricadigitale/webcomponents ... Anyway monday I'll look at it.

Thanks @KeithHenry !

leodido commented 6 years ago

Hey @KeithHenry I looked at the code and it looks good to me.

But there are some things to adjust/complete. Namely,

  1. Rewording the commit message following our commit conventions

    1.1. In this case your commit message should be something like "New: Icon support for autocomplete items"

  2. Rebasing the PR on top of the current develop removing conflicting, old, and merge (also mine) commits from this PR. I have not access to your fork's branch otherwise I could help you to do it.

  3. Update tests (Currently 16 of 116 fails since they test against paper-item within autocomplete dropdown, not against paper-icon-item)

Can you kindly finish this excellent job? :)

Thanks in advance.

KeithHenry commented 6 years ago

@leodido Ok, I'll take a look when I get the chance.