search

fabbricadigitale / paper-chip

A chip web component made with Polymer 2 following Material Design guidelines
http://webcomponents.org/element/fabbricadigitale/paper-chip
MIT License
31 stars 16 forks source link

New: Icon support for paper-chip-input #71

Closed microDimensions closed 6 years ago

microDimensions commented 6 years ago

This PR picks up where https://github.com/fabbricadigitale/paper-chip/pull/68 left, fixing the unit tests and the commit message.

feuerste commented 6 years ago

@leodido Would you be so kind to review this PR? Thanks a lot!

leogr commented 6 years ago

Hi @microDimensions @feuerste ! Thank you for this PR! Could you add an usage example in demo?

feuerste commented 6 years ago

Hi @leogr I added two examples.

leodido commented 6 years ago

Code looks good. Thanks.

Anyway there are issues with tests setup. I think it is related to wct. Locally can you run them?

feuerste commented 6 years ago

Yes, I can run them successfully locally.

leogr commented 6 years ago

I can run them locally too. The issue with travis seems to be related to saucelabs. I'll investigate.

leodido commented 6 years ago

Anyway I merge it since the last commit passed (the one with travis/saucelabs issue can not interfer with tests...).

feuerste commented 6 years ago

Cool, thanks