search

fabbricadigitale / scimd

SCIM v2 golang implementation
MIT License
5 stars 1 forks source link

Special attributes with business logic (eg. "password") #48

Open leogr opened 6 years ago

leogr commented 6 years ago

It's needed to implement a way to apply the internal service provider logic to some attributes. For example, password must be hashed prior to being stored.

Middleware pattern could be useful to accomplish that.

leogr commented 6 years ago

Has been this feature fully implemented?

alelb commented 6 years ago

Hi @leogr, have you had a look to f9b0edb9047497b8a0777ae154f950817dc9bb19? There is no support for compare more than one password in a search request.

leogr commented 6 years ago

It's dirty... btw is it working?

leodido commented 6 years ago

@alelb news pls?

alelb commented 6 years ago

@leogr @leodido It's dirty and rough but It's working . It's missing the ability to compare more than one password per query. It's missing tests too.

leogr commented 6 years ago

Assuming a dirty solution, I propose to implement integration test only (short-term), so when we change the implementation we can test the correct behaviour. @leodido Do you agree?