search

fabcity / newfabcity

Fab City website
https://old.fab.city
Apache License 2.0
1 stars 4 forks source link

Logo on landing needs to be changed #5

Closed Katearmstrong4 closed 5 years ago

Katearmstrong4 commented 6 years ago

The logo needs to be the colour version on the black background of the landing page, and change to plain black version on scroll down when it meets the white background.

OR

Logo on landing can be white and change to black

viktorsmari commented 6 years ago

What about adding a white background behind the logo and the hamburger menu? Because on smaller devices you can get many different colors behind the logo when you scroll down. Examples: 2018-10-18_15-35-57 And the footer: 2018-10-18_15-36-30

Katearmstrong4 commented 6 years ago

Good point, let's see what that looks like. If not, the colour logo will solve it!

On Thu, 18 Oct 2018 at 15:37, Viktor Smári notifications@github.com wrote:

What about adding a white background behind the logo and the hamburger menu? Because on smaller devices you can get many different colors behind the logo when you scroll down. Examples: [image: 2018-10-18_15-35-57] https://user-images.githubusercontent.com/1689020/47158271-92fcf900-d2eb-11e8-8a1a-43a3d68a2c81.png And the footer: [image: 2018-10-18_15-36-30] https://user-images.githubusercontent.com/1689020/47158292-9bedca80-d2eb-11e8-97f8-479b3428c999.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/fabcity/newfabcity/issues/5#issuecomment-431011282, or mute the thread https://github.com/notifications/unsubscribe-auth/Aiy6qiQXYgL6y7Bwk0UBP0OecYs1ibEaks5umIQBgaJpZM4XtaNW .

-- Kate Armstrong Fab Lab Barcelona | IAAC Telegram/WhatsApp: +34675441150 Fab.City Global Initiative

See Legal Data protection and confidentiality http://iaac.net/legal-notice-data-protection-and-confidentiality/ Ver Aviso legal de protección de datos y confidencialidad http://iaac.net/legal-notice-data-protection-and-confidentiality/ Veure Avis legal de protecció de dades i confidencialitat http://iaac.net/legal-notice-data-protection-and-confidentiality/

viktorsmari commented 6 years ago

Check out PR #8

Katearmstrong4 commented 6 years ago

So finally, change logo to colour version (see bottom right) and burger to the fab city flag colours :-) R,G,B... ;-)

captDaylight commented 5 years ago

This looks like it can be closed right?

viktorsmari commented 5 years ago

Correct, thank you @captDaylight !

viktorsmari commented 5 years ago

Ah, I don't have permission to close it. @Katearmstrong4 will need to do that :)