search

fabd / kanji-koohii

A web application to help Japanese language learners remember the kanji.
https://kanji.koohii.com
GNU Affero General Public License v3.0
225 stars 21 forks source link

Refresh the Flashcard Review page design #10

Open fabd opened 7 years ago

fabd commented 7 years ago

I liked the Material Theme that @magnonellie made for Kanji Koohii. It reminded me the Flashcard Review page looks pretty cheesy today (imho) with some web2.0 vibes still in a few places.

(Though I would probably put a light theme by default, it would make a dark theme much easier by just changing the colours)

Use flat or semi-flat design that is more at home on iOS / Android as well as current desktop designs.

Practically speaking

dotellie commented 7 years ago

Wow! I had no idea you had a github repo for Kanji Koohii! I haven't had a look through the sources yet, but it's possible that I could handle this one if you want me to. :smile:

EDIT: Well, scratch that xD

fabd commented 7 years ago

@magnonellie

We had a small Google Group going with testers who answered my call for mobile testers on the site news. Recently I've decided to move to github to handle the feedback, bugs and suggestions. Still have a bunch of issues that I need to add here from the earlier feedback.

The full source was on Github some years ago but it didn't work for me then. Now I'll do it in much smaller steps so it actually is productive. Over time I hope to publish some components built with Vue JS 2. So that the more up to date code is exposed without me having to wrangle contributions into all the legacy code I have to handle. So this requires me to use a more "component based" approach. The downside is that I have to produce separate smaller repos. But on the plus side I guess I can share back some small things. One of the things I can start with for example would be to put up the mobile navigation I've put together (more like hacked together but I couldn't find a Vue JS 2 complete solution for an off canvas + expand/collapsible menu).

Regarding this issue and design questions in general it's best to propose changes via a picture anyway because you'd find it quite unwieldy to have to wrangle through all the Javascript, php view templates and stylesheets. The Flashcard Review page is some of the oldest code on the site. There wasn't any SCSS / SASS / "BEM" etc. back then. A lot of things are also going to change, such as eventually refactoring that page as a Vue JS component which would make a lot more sense and much easier to maintain. So TLDR it would be too impractical to work with the code directly :)

dotellie commented 7 years ago

@fabd Sorry, I kind of missed those posts and figured it was too late once I saw them. About the code, I can see where you're coming from, but I also think that is no point holding it back just because it's old code. Everyone has that embarrassing piece of code they wrote years ago and honestly, I just think it's fantastic that you're still maintaining that code. I for one would be glad to help tidy up the code, but you obviously have the final decision on how you want to handle all of that. I guess that you might not have coded the site in a way that is friendly to just be putting up all the source, so I guess that also contributes to it.

At any rate, if you ever have anything you think would be fitting to assign to me (when you have some code up), by all means, give me a mention. :wink: