Implement "Next day starts at ___ hours past midnight" SRS Option

[fabd]

Discussed in https://github.com/fabd/kanji-koohii/discussions/248

^{Originally posted by **bradenpecora** February 23, 2022} Hi Fabrice, As always, huge fan of the site. I appreciate your work very much. -- As someone who frequently goes to bed past midnight, I often have to remember to do my SRS kanji reviews before midnight. If I forget to do that, I'm forced to combine two days of SRS. Anki has an option called "Next day starts at ___ hours past midnight" that allows you to choose when the next SRS day starts at. This would be a very useful feature to me that doesn't seem to difficult to implement. If you like this feature but don't have the time to implement it, I could try my hand at creating a pull request... I'm a bit of a novice, but I'll try me best! Thanks!

[fabd]

Account > Timezone setting : add a descrtiptive label to say exactly when the SRS update happens #57

[fabd]

Likely steps, brainstormed in "Next day starts at" Option #248

• add a Next day starts at ___ hours past midnight setting in the Spaced Repetition Screen, which is a Vue component, https://github.com/fabd/kanji-koohii/blob/master/src/vite/src/vue/account/SpacedRepetitionForm.vue
• the form is instanced from this php template https://github.com/fabd/kanji-koohii/blob/master/src/apps/koohii/modules/account/templates/spacedrepetitionSuccess.php
• the form POST would have to be handled in https://github.com/fabd/kanji-koohii/blob/master/src/apps/koohii/modules/account/actions/actions.class.php#L472
• the option would need to be added to the UsersSettingsPeer db model https://github.com/fabd/kanji-koohii/blob/master/src/lib/peer/UsersSettingsPeer.php
• the mysql schema updated with an incremental sql file in this folder https://github.com/fabd/kanji-koohii/blob/master/src/data/schemas/incremental/README.md
• I would probably add a sqlMidnightTime to UsersPeer, as I';m not sure all the other places sqlLocalTime is used and what side effects it would have to change the existing method https://github.com/fabd/kanji-koohii/blob/master/src/lib/peer/UsersPeer.php#L309 - this would essentially do sql DATE( x ) of what the existing function returnsm truncating the HMS, so it is a localized midnight time
• then use that in ReviewsPeer::getFLashcardsForReview https://github.com/fabd/kanji-koohii/blob/master/src/lib/peer/ReviewsPeer.php#L530 instead of sqlLocalTime, - EDIT and add user's nextdaystartsat setting ; therefore then the midnight time used in the due card selection would take in account the user's Next day starts at setting

[fabd]

Also maybe then set the default value of this setting to 5 AM or so ?

[fabd]

Hmm, it does look like sqlLocalTime is only used in the code in reference to expiredate , always to select DUE or UNDUE cards in queries.

it is also used in getTodayCount() to find flashcards reviewed "today" - which can also adjust for the "next day starts at" setting.

So in theory sqlLocalTime itself could be modified to add the user's "Next day starts at" setting.