search

fabd / kanji-koohii

A web application to help Japanese language learners remember the kanji.
https://kanji.koohii.com
GNU Affero General Public License v3.0
224 stars 21 forks source link

Lesson progress bar does not look correctly on mobile #306

Closed UncomprehendingGale closed 1 year ago

UncomprehendingGale commented 1 year ago

Lesson progress bar on chrome mobile doesn't appear at all, it is just dots Screenshot_2023-03-31-19-56-59-10_40deb401b9ffe8e1df2f1cc5ba480b12 My phone is a OnePlus 10 in case it matters

fabd commented 1 year ago

Also closes #265

fabd commented 1 year ago

Hey @UncomprehendingGale I've just updated the live site with various "mobile friendly" improvements to the Lesson progress bars. The "All Lessons" page and the homepage Dashboard have also been optimized to fit better.

I don´t have the time to update the blog atm. But until then please keep me updated if the changes work well, and/or if something is still buggy.

I'm also interested if some elements are a little too big or small overall. I don't have a smartphone, so I'm eyeballing all of this on the preview in Google Chrome dev tools.

fabd commented 1 year ago

Here's what I'm seeign in my preview:

localhost_index_dev php_progress(iPhone SE)

And Dashboard :

dasdhaboawrds

UncomprehendingGale commented 1 year ago

Yes, it all looks correct, thanks a lot!

Maybe i'll take this chance to bother you about something else, the font on the percentage progress is uneven, even in your own screen we can see that the second 6 in "6.6%" is a bit smaller

fabd commented 1 year ago

Maybe i'll take this chance to bother you about something else, the font on the percentage progress is uneven, even in your own screen we can see that the second 6 in "6.6%" is a bit smaller

Hah,... someone else mentioned this a while ago. Is it that noticable? Maybe it's more noticeable on a smartphone display with retina resolution? I guess I could change it, it was meant to make the fractional part stand out.

fabd commented 1 year ago

Closed by #309