fabd / kanji-koohii

A web application to help Japanese language learners remember the kanji.
https://kanji.koohii.com
GNU Affero General Public License v3.0
228 stars 21 forks source link

Restore RTK1/RTK3 filter in the "Spaced repetition" review section #61

Open SebastianGG opened 7 years ago

SebastianGG commented 7 years ago

Originally there was a filter for displaying all cards, or only RTK1 or RTK3 cards and reviewing them. In the new design, the filter is gone and there's no way to review cards from only one of the books.

This can be a big issue, especially for people with lots of due cards who want to catch up on RTK1 before tackling their due RTK3 cards.

fabd commented 7 years ago

(Labelled feedback since I made a news post about issues gathering feedback.)

I understand I removed something that was there. There are a few reasons this happened:

So TLDR first : I don't have any plans to bring back this soon , unless more people come forward.

The longer rumination:

The site currently has hardcoded things like this RTK 1 / RTK 3 progression. I think this is not flexible enough, and in the future I would like to support something like "goals". At first I would convert RTK 1 and RTK 3 to individual goals. Each goal then has its own progress bar, and goals would be displayed on the Home screen.

A similar way of filtering the SRS chart by goals could be needed. The only issue I have right now is that I would have to write more outdated JS using the JS I'm trying to phase out, dealing with ajax request, plus refreshing the VueJS comp after an ajax call. So if I don't absolutely need to , I'd much rather consider it is gone until I bring it back in a better form... then spend time writing code I will throw away again later.

That said, do you absolutely need to review these cards by RTK volume?

Assuming you added RTK 3 after you completed RTK 1, in general you will have much more of RTK 1 due cards in the 5-6-7+ piles, and RTK 3 in the lower piles. In that case you could whittle down due piles starting from the right by selecting the pile in the SRS chart (something that was fixed recently).

SebastianGG commented 7 years ago

I was surprised when I noticed the missing filter in the new review page, and thought it was an oversight that would be easy to repair and that more people used it regularly. If it's more work than I thought and people don't use it much at all anyway, I see your point.

All my RTK3 cards are due, and it will probably take me longer to finish my due cards from RTK1 than it will take you to make the RTK1/RTK3 filter available again, so I guess I'll have to delete all RTK3 cards and add them again once I'm done catching up with RTK.