search

fabdavid / asap2_web

GNU General Public License v3.0
3 stars 4 forks source link

Costly line in Dockerfile #1

Closed A-Alaa closed 6 years ago

A-Alaa commented 6 years ago

https://github.com/fabdavid/asap2_web/blob/0abcd1772e9a7bf1e505df355016786afdc1e975/Dockerfile#L12

I think this particular line might be avoided, since it is redundant to the following command, and costs 3.6 GB of storage and copying-time:

docker cp db/asap2.dump <WEBSITE_CONTAINER_ID>:/dumps/asap2.dump
fabdavid commented 6 years ago

Yes I agree. Let's delete this line. I think it was even not working properly, that's why I had to add the docker command.