faberNovel / docker-android

docker-android provides general purpose docker images to run CI steps of Android project.
61 stars 13 forks source link

Add default Fastlane install #49

Closed vincentbrison closed 4 years ago

vincentbrison commented 4 years ago

As we already providing default ruby env, and default bundler install, we should provide a default Fastlane install.

It would allow faster setup to user using the same version, and does not want to rely on ruby cache install.

It would also make sense in the context of using the docker image as a dedicated GitHub Action (see #45)

vincentbrison commented 4 years ago

Any thoughts @sjcqs?

sjcqs commented 4 years ago

It would have to be updated every time fast lane is updated.

I'm not sure how much time could be saved by providing a default version

vincentbrison commented 4 years ago

It makes sense. I will keep this open, so we can discuss it, maybe when image as action will be ready, since it would be the main use case. Will see!

sjcqs commented 4 years ago

There's an issue if we provide fastlane out-of-the-box:

Maybe, we can instead add an option like run_bundle_install to the Github Action to run bundle install so that fastlane and any dependencies will be installed by the action inside the entrypoint. Or even install_fastlane which would either:

I don't think there's a lot of added value though 🤔

vincentbrison commented 4 years ago

Yes, not sure its a good idea, as installing Fastlane is fast (few seconds) and can be cached, VS ruby install for example, which can take few minutes.

For me it is up to the image / action consumer to define its workflow, which maybe does not involve fastlane at all. So we could add such option as run_bundle_install but at the end, we may hide things through this behavior, which can lead to confusion.

vincentbrison commented 4 years ago

Can I close this issue @sjcqs? We could re-open and re-evaluate our mind if someone comes with new ideas at the table.