fabfuel / ecs-deploy

Powerful CLI tool to simplify Amazon ECS deployments, rollbacks & scaling
Other
857 stars 148 forks source link

ecs deploy lost EFS mount on Fargate Task #136

Closed lczerepuk closed 3 years ago

lczerepuk commented 4 years ago

Hello,

During change image in Task Definition by "ecs deploy" command I noticed that ecs-deploy lost EFS Volume Configuration, like Access Point ID, Root Directory, Encryption in transit, Transit port, EFS IAM Auth and left only "Name" and "Volume Type" with value Mount.

With ecs-deploy command:

Volumes

Name
efs-const
Volume type
Bind Mount

Name
efs-mnt-logs
Volume type
Bind Mount

Without ecs-deploy command:

Volumes:

Name
efs-const
Volume type
EFS
File system ID
fs-xxxx
Access point ID
fsap-xxxx
Root directory
/
Encryption in transit
ENABLED
Transit port
2999
EFS IAM authorization
DISABLED

Name
efs-mnt-logs
Volume type
EFS
File system ID
fs-xxxx
Access point ID
fsap-xxx
Root directory
/
Encryption in transit
ENABLED
EFS IAM authorization
DISABLED
LimmaPaulus commented 4 years ago

I am experiencing exactly same problem.

LimmaPaulus commented 4 years ago

I found out that the problem is just outdated boto3 version. Provided docker image has boto3 version 1.11.13. After installing the latest version (1.14.47), everything works fine. This is logical, because EFS mounts with Fargate is published just some months ago.

LimmaPaulus commented 4 years ago

I will personally use following Dockerfile before we get new release. This works well.

FROM fabfuel/ecs-deploy

RUN pip3 install --upgrade pip boto3
fabfuel commented 4 years ago

Thanks @LimmaPaulus! I will bump up the boto3 version in the requirements and create a new release

lczerepuk commented 4 years ago

Thanks everyone for helping. ;-)

fabfuel commented 4 years ago

Hi guys,

can you confirm, that the issue is solved when using Docker tag 1.10.2?

docker run fabfuel/ecs-deploy:1.10.2 ecs ...

Thanks! Fabian

lczerepuk commented 3 years ago

It works, thanks 👍