search

fabfuel / ecs-deploy

Powerful CLI tool to simplify Amazon ECS deployments, rollbacks & scaling
Other
854 stars 148 forks source link

Incorrect line wrap in Chrome and Firefox in deploy_task_definition #191

Closed F1ashhimself closed 2 years ago

F1ashhimself commented 2 years ago

It looks like Chrome (97.0.4692.71) and Firefox have incorrect line wrapping for such lines like on screenshot and it tries to wrap line right before last symbol. And it is reproducible with different window resolutions.

Screenshot 2022-01-11 at 19 00 30

But in Safari all looks good.

It can be avoided if we will add space or new line between words and dots here https://github.com/fabfuel/ecs-deploy/blob/af252d2035a5542a0581f408b55a0976c784da0c/ecs_deploy/cli.py#L494 like

click.secho(f'{title} ', nl=False)
fabfuel commented 2 years ago

Hi Max, thats an interesting issue! 🙂
May I ask what tool you're using in the browser which causes this?

Best Fabian

F1ashhimself commented 2 years ago

@fabfuel sorry for late answer, I think this is our company internal tool for deployment. But there are no special css for wrapping this.

fabfuel commented 2 years ago

No problem. I already added a line break before the "waiting dots" (https://github.com/fabfuel/ecs-deploy/commit/289c51b0521999d21a946d0d81b12c38e440e6a2). It's in the develop branch and will be part of the next release.

Best Fabian

F1ashhimself commented 2 years ago

Thank you very much.