search

fabfuel / ecs-deploy

Powerful CLI tool to simplify Amazon ECS deployments, rollbacks & scaling
Other
843 stars 145 forks source link

Relax click version constraint #194

Closed ero5004 closed 2 years ago

ero5004 commented 2 years ago

This PR relaxes the version constraint of the click dependency so that versions above 8.0 can be installed. We had to update the version of celery that our app was using (previously 5.0.5) because of a critical security alert. We upgraded to celery 5.2.2 which requires click >=8.0,<9.0 but because ecs-deploy had locked click to 7.1.2, we could not do this.

fabfuel commented 2 years ago

Thanks Eric, it seems to work fine with the newer version of Click.

Out of curiosity, would you share your use-case, in which you use eco-deploy in conjunction with Celery?

Best Fabian

ero5004 commented 2 years ago

Appreciate it @fabfuel ! We are working on a django web app that uses celery workers to process background tasks, etc.. We use ecs-deploy in a GitHub action to build and deploy images to our staging environment. Happy to chat more about it if you'd like!

Thanks!

Eric