search

fabi1cazenave / webL10n

Client-side internationalization / localization library
http://fabi1cazenave.github.com/webL10n/
278 stars 70 forks source link

I think it makes more sense to dispath the localized event on document instead of window. #12

Closed sonnyp closed 11 years ago

sonnyp commented 12 years ago

s/dispath/dispatch

fabi1cazenave commented 11 years ago

Agreed but document is not an event target, says @mounirlamouri (and in Mounir we trust)

sonnyp commented 11 years ago

http://www.w3.org/TR/DOM-Level-2-Events/events.html#Events-EventTarget "The EventTarget interface is implemented by all Nodes in an implementation which supports the DOM Event Model."

document is a Node and so, an event target

fabi1cazenave commented 11 years ago

/me grumbles

mounirlamouri commented 11 years ago

Oh, indeed. However, our implementation doesn't do that. We have the following hierarchy: nsIDOMHTMLDocument < nsIDOMDocument < nsIDOMNode < nsISupports

I remember that I spoke with smaug about that. He might know more about this.

sonnyp commented 11 years ago

Please see #21