Add support for attributes in webL10n.get, and corrected behavior of the fallback argument - Githubissues

fabi1cazenave / webL10n

Client-side internationalization / localization library

http://fabi1cazenave.github.com/webL10n/

278 stars 70 forks source link

Add support for attributes in webL10n.get, and corrected behavior of the fallback argument #38

Closed Rob--W closed 9 years ago

Rob--W commented 11 years ago

Before this PR, it was impossible to programatically get the value of an localized attribute. I checked the implementation of how attributes in the properties file are parsed, and derived a method that recognized attributes, if specified.

Read commit message of dd0703a662a623e550317e3437f6850796606e9c for an explanation of the second change set. In a nutshell:

Initial implementation: webL10n.get('non_existent', null, 'fallback') === 'fallback'
Later implementation: webL10n.get('non_existent', null, 'fallback') === ''; (expected 'fallback')
My commit = back to initial implementation

fabi1cazenave commented 9 years ago

Thanks for this patch @Rob--W, and sorry for having missed it. My bad.