Closed jahirfiquitiva closed 2 years ago
Thank you very much for your feedback! I mainly use the dark theme, so I focused on that during development. I will take another look at the colors of the light theme. I will give you an update in the coming days.
@fabian-hiller awesome, thanks!
Hey @jahirfiquitiva, I added a Light+ theme with higher contrast. Once you update the theme to v0.2.0, it should show up in the list. Do you think the contrast is sufficient? Feel free to leave me feedback on it here!
@fabian-hiller thanks for the update. I checked and all colors contrast ratio still fail except for the red and purple shades.
Anyway, the texts are easier to read now, so it's definitely an improvement, thanks!
Btw, I found another issue with unused
(?) variables or lines ... the text is even less visible and much harder to read 😕 it would also be great if you could take a look at it.
Thanks again for the feedback! Would you recommend raising the contrast another notch? In this case, the colors will continue to lose some of their "color".
Btw, I found another issue with unused (?) variables or lines ...
Thank you for pointing that out, of course it shouldn't be like that. I will have a look at it in the next few days.
@fabian-hiller yeah, I would recommend making the colors a bit darker. Another thing maybe you could try is not using white for the background for rather a light shade of gray like #FAFAFA
or #ECEFF1
🤔
I made the colors a bit darker again and added a new theme called Light++. Feel free to give me feedback compared to the Light+ theme.
I also experimented with the background color. However, I didn't like the results, so I stuck with the white background. If you want to customize the theme to your needs, you can create a fork or just copy the code.
@fabian-hiller Thank you so much! it looks much better... do you think it would be possible to keep both Light+ and Light++? That would allow people to choose the one they like better or fits better to their visual conditions 🤔
Sorry for the late feedback. Until version 1.0, I'm open to experimentation. Can you think of a better name for the themes that draws attention to the difference in contrast?
@fabian-hiller i'm bad at naming things 😆 but maybe:
Let's keep for now the current names. Thanks again for your feedback! 🚀
Hey, I recently found this theme and I'm really enjoying it. Anyway, the light theme colors are a bit hard to read for me.
I checked the contrast ratio of them and they all fail in terms of accessibility. I used contraste for checking that.
Would you mind updating the colors to a darker shade, or maybe creating a high contrast variant with colors easier to read?
Thanks in advance.