Open jahirfiquitiva opened 2 years ago
Thank you for your feedback! I am aware of the slight color difference. Personally, it hasn't bothered me so far. I will take a look at it with Fuchsia
in the coming days.
@fabian-hiller yeah, it isn't that bad, I just think it would be good to make the difference more noticeable π
I tested it with the color Fuchsia
. For my taste, it ruins the overall look. Therefore, I would like to stay with the previous color for now.
@fabian-hiller Any chance of having it as a variant? π π
Yes, can you think of a suitable name?
@fabian-hiller what do you think about Pop
? π€
This could work. In the long term, I prefer to have one or at most two variants of Dark and Light again, which correspond to my ideas. So it might be a good idea for you to fork the project and create your own theme out of it. On YouTube you can find videos about it. Have a great start to the week!
It's difficult to distinguish keywords and textsποΈ
Can you send me a screenshot and highlight the text you would change the color of? Do you have a color recommendation?
@fabian-hiller
I think we mean these texts:
The colors shades are really similar.
Here are some color suggestions that can be used for one of those (maybe the const
keywords) for the different themes
Light | Light+ | Dark |
---|---|---|
#5f27cd |
#341f97 |
#ff9ff3 |
#786fa6 |
#574b90 |
#f8a5c2 |
#6c5ce7 |
#4C40A2 |
#B5AFFE |
#5851DA |
#4834d4 |
#ED9AFE |
When I use these variables, I cannot determine by color whether they have been declared, as they are all white like texts. This creates a significant usage burden
@jahirfiquitiva I am still not quite sure what you mean. Do you think the color of const
and fetchSelfFeed
are too similar?
@BaiJiang007 what color should it be? Blue? Can you create a PR?
@fabian-hiller yes, the colors of const
and fetchSelfFeed
are too similar
Thanks for your feedback. Personally it doesn't bother me and at the moment I don't have time to work on it as I'm focused on Valibot. But feel free to fork and customize this theme.
Hey, I wanted to ask if it's possible to change the colors used for
const
and types, as it's close to the green for class names which makes it a bit confusing.Maybe the
Pink
orFuchsia
colors could fit the palette plus make those texts more distinguishable.Thanks!
Even the preview image has this "issue"