fabian-hiller / vscode-pace-theme

An elegant VS Code theme optimized for developers with a high pace
MIT License
33 stars 0 forks source link

[Request] Change color for keywords and types #2

Open jahirfiquitiva opened 2 years ago

jahirfiquitiva commented 2 years ago

Hey, I wanted to ask if it's possible to change the colors used for const and types, as it's close to the green for class names which makes it a bit confusing.

Maybe the Pink or Fuchsia colors could fit the palette plus make those texts more distinguishable.

Thanks!

Shot 2022-09-04 at 13 54 22@2x

Even the preview image has this "issue" Dark theme preview image

fabian-hiller commented 2 years ago

Thank you for your feedback! I am aware of the slight color difference. Personally, it hasn't bothered me so far. I will take a look at it with Fuchsia in the coming days.

jahirfiquitiva commented 2 years ago

@fabian-hiller yeah, it isn't that bad, I just think it would be good to make the difference more noticeable πŸ˜…

fabian-hiller commented 2 years ago

I tested it with the color Fuchsia. For my taste, it ruins the overall look. Therefore, I would like to stay with the previous color for now.

jahirfiquitiva commented 2 years ago

@fabian-hiller Any chance of having it as a variant? πŸ™ πŸ˜…

fabian-hiller commented 2 years ago

Yes, can you think of a suitable name?

jahirfiquitiva commented 2 years ago

@fabian-hiller what do you think about Pop? πŸ€”

fabian-hiller commented 2 years ago

This could work. In the long term, I prefer to have one or at most two variants of Dark and Light again, which correspond to my ideas. So it might be a good idea for you to fork the project and create your own theme out of it. On YouTube you can find videos about it. Have a great start to the week!

BaiJiang007 commented 3 months ago

It's difficult to distinguish keywords and texts😭️

fabian-hiller commented 3 months ago

Can you send me a screenshot and highlight the text you would change the color of? Do you have a color recommendation?

jahirfiquitiva commented 3 months ago

@fabian-hiller

I think we mean these texts: Image 188329117

The colors shades are really similar.

Here are some color suggestions that can be used for one of those (maybe the const keywords) for the different themes

Light Light+ Dark
#5f27cd #341f97 #ff9ff3
#786fa6 #574b90 #f8a5c2
#6c5ce7 #4C40A2 #B5AFFE
#5851DA #4834d4 #ED9AFE
BaiJiang007 commented 3 months ago

image When I use these variables, I cannot determine by color whether they have been declared, as they are all white like texts. This creates a significant usage burden

fabian-hiller commented 3 months ago

@jahirfiquitiva I am still not quite sure what you mean. Do you think the color of const and fetchSelfFeed are too similar?

@BaiJiang007 what color should it be? Blue? Can you create a PR?

jahirfiquitiva commented 3 months ago

@fabian-hiller yes, the colors of const and fetchSelfFeed are too similar

fabian-hiller commented 3 months ago

Thanks for your feedback. Personally it doesn't bother me and at the moment I don't have time to work on it as I'm focused on Valibot. But feel free to fork and customize this theme.