fabian-lauer / dbus-shelly-3em-smartmeter

Integrate Shelly 3EM smart meter into Victron Energies Venus OS
125 stars 55 forks source link

energy values are wrong #2

Closed vikt0rm closed 2 years ago

vikt0rm commented 2 years ago

Hi Fabian,

i was not able to create a branch to fix it on my own. Here the fix:

Changing to value from "power" to "total" for Forward like:
self._dbusservice['/Ac/L1/Energy/Forward'] = meter_data['emeters'][0]['total']/1000 if meter_data['emeters'][0]['total'] > 0 else 0 Changing to value from "power" to "total_returned" for Reverse like:
self._dbusservice['/Ac/L1/Energy/Reverse'] = (meter_data['emeters'][0]['total_returned']/1000) if meter_data['emeters'][0]['total_returned'] < 0 else 0

This change works on my setup like expected.

BR, Viktor

fabian-lauer commented 2 years ago

Hi,

Thanks for info. I was looking a round for a couple of days to find my error - found it this morning🙈

Fix is almost the same….thanks for your help …. A few days early would have been even better 😁

Will push changes during the next hours

Cheers Fabian


Von: vikt0rm @.> Gesendet: Monday, March 28, 2022 11:19:08 AM An: fabian-lauer/dbus-shelly-3em-smartmeter @.> Cc: Subscribed @.***> Betreff: [fabian-lauer/dbus-shelly-3em-smartmeter] energy values are wrong (Issue #2)

Hi Fabian,

i was not able to create a branch to fix it on my own. Here the fix:

Changing to value from "power" to "total" for Forward like: self._dbusservice['/Ac/L1/Energy/Forward'] = meter_data['emeters'][0]['total']/1000 if meter_data['emeters'][0]['total'] > 0 else 0 Changing to value from "power" to "total_returned" for Reverse like: self._dbusservice['/Ac/L1/Energy/Reverse'] = (meter_data['emeters'][0]['total_returned']/1000) if meter_data['emeters'][0]['total_returned'] < 0 else 0`

This change works on my setup like expected.

BR, Viktor

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffabian-lauer%2Fdbus-shelly-3em-smartmeter%2Fissues%2F2&data=04%7C01%7C%7C5449ef883b7f4d5ccddb08da109c03bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637840559511873962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=GRUyGeB3w32TD%2FlhjKV0T6nyZXu5qYRzmLVP87cJZ%2BE%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAYIXMTXJZSRE7NKHEIXQN5LVCF2QZANCNFSM5R2PQEKA&data=04%7C01%7C%7C5449ef883b7f4d5ccddb08da109c03bb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637840559511873962%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=b9LO4A8mb8BDwnsvvjB5mmfbdYYuS2IK2vVkQbJgEmU%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>

fabian-lauer commented 2 years ago

Problem has been fixed - new release v0.2 is out

vikt0rm commented 2 years ago

Sorry I installed Venus OS on my raspi just the day before yesterday :) but I was able to make fast progress 👍 Thank you for your inspiration!